Fixes #875: Add accuracy to LocationData (when available) #876
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/lyokone/flutterlocation~876 Documentation is deployed and generated using docs.page. |
packages/location/README.md
Outdated
| @@ -172,7 +172,7 @@ class LocationData { | |||
| final double accuracy; // Estimated horizontal accuracy of this location, radial, in meters | |||
| final double altitude; // In meters above the WGS 84 reference ellipsoid | |||
| final double speed; // In meters/second | |||
| final double speedAccuracy; // In meters/second, always 0 on iOS | |||
| final double speedAccuracy; // In meters/second, always 0 on iOS, web | |||
There was a problem hiding this comment.
I think you missed something here?
There was a problem hiding this comment.
According to docs here: https://developer.mozilla.org/en-US/docs/Web/API/GeolocationCoordinates, speedAccuracy is not available on web so it will always be zero.
There was a problem hiding this comment.
I think if we change to this though, we should just change the documentation to state that all coordinate parameters are 0 if missing (this could be a dangerous way to handle this though).
Edge cases that this can cause some unintended consequences:
- Speed is actually 0 (user is not moving). Developer would have a hard time knowing if it was missing or truly zero.
- Same goes for heading?
Maybe we should make these Null if missing to avoid this?
There was a problem hiding this comment.
Yeah, I think using null for missing values is a good idea. Are you up to contributing this as well? :)
There was a problem hiding this comment.
Yea, sign me up. We will keep this PR open and I will make these changes?
There was a problem hiding this comment.
@bartekpacia maybe a dumb question, but what is the best practice after forking the repo to test the changes with the example folder in the location package? I would like to run the example code and have it use the changes to the location_web package, but it is using the pub.dev location_web package.
For now, I am changing the pubspec to use local, just wondering if there is a better way.
There was a problem hiding this comment.
Melos solves this problem. Run melos bootstrap in this project's root directory and it'll locally override ("link together") all the packages.
Yes! |
|
Thanks, released in v4.2.0 😎😎😎 |
Fixes #875