Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on and support Android 12 (SDK 31). #640

Conversation

PieterAelse
Copy link

@PieterAelse PieterAelse commented Sep 28, 2021

Fixes #639
Fixes #702

@PieterAelse
Copy link
Author

@Lyokone Could you have a look at this PR and get it merged? In order to support Android 12!

@chedwin41
Copy link

Hi @Lyokone, could you have a quick look to this PR ? This is the only package left so I can migrate my app to Android 12.
Thanks a lot !

@PieterAelse
Copy link
Author

@Lyokone any updates on merging this PR to unblock everybody from building on Android 12?

@magnuswikhog
Copy link

@Lyokone Any plans to merge this pull request in the near future? This issue is really blocking a lot of app releases.

@rubenaster
Copy link

@Lyokone any updates on that current topic? Can we help? Unfortunately this prevents Android 12 devices from running the application.

@note11g
Copy link

note11g commented Feb 11, 2022

@Lyokone Please merge this PR....

@PieterAelse
Copy link
Author

PieterAelse commented Feb 11, 2022

Did not try it myself, but in the mean-time maybe everybody who is blocked can use the following:

dependencies:
  flutterlocation:
    git:
      url: [email protected]:pieteraelse/flutterlocation.git
      ref: build_on_and_support_android_12_sdk_31

Source: https://dart.dev/tools/pub/dependencies#git-packages

@carloserazo47
Copy link

carloserazo47 commented Mar 8, 2022

Did not try it myself, but in the mean-time maybe everybody who is blocked can use the following:

dependencies:
  flutterlocation:
    git:
      url: [email protected]:pieteraelse/flutterlocation.git
      ref: build_on_and_support_android_12_sdk_31

Source: https://dart.dev/tools/pub/dependencies#git-packages

Thanks @PieterAelse, it works well with your fork but you have to set the path as well:

dependencies:
  location:
      git:
        url: https://github.com/PieterAelse/flutterlocation.git
        path: packages/location
        ref: issue_639/build_on_and_support_android_12_sdk_31

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Apr 16, 2022
@PieterAelse
Copy link
Author

@Lyokone trying to unflag as it's not stale

@stale stale bot removed the inactive label Apr 16, 2022
@lukaskurz
Copy link

How is this still not merged? Nearly half a year since the creation of the PR has passed, without any direct feedback of the maintainer @Lyokone . I understand that they are in the process of a new major version, but I think merging code from the community should still be possible in the meantime. I would greatly appreciate it (and I'm sure others would too), if you could quickly take a look at this and merge it.

@akhatriST
Copy link

@Lyokone Any chance of the PR getting merged of the fix?

btw How is everyone tackling this issue?

@lukaskurz
Copy link

@akhatriST I just forked the repo, merged the contents of all the PRs which were needed and use that repo for now.

@xunreal75
Copy link

xunreal75 commented Sep 8, 2022 via email

ecarrara added a commit to buserbrasil/flutterlocation that referenced this pull request Mar 29, 2023
@Cotspheer
Copy link

@Lyokone any chance to get this merged?

@PieterAelse
Copy link
Author

@bartekpacia Since you closed #639 in favor of #702 (a newer issue? but okay..), could you review this PR to get it merged?

@bartekpacia
Copy link
Collaborator

Will take a look at it soon and hopefully merge

a newer issue? but okay..

I was just trying to clean up the repo, many issues had often ~5 duplicates, so I wasn't really looking which one was newer

@bartekpacia
Copy link
Collaborator

The build is failing.

@PieterAelse
Copy link
Author

@bartekpacia Looks like the main change of my PR is already done on master now: 187734c

Maybe this PR can be closed, if you agree.

@bartekpacia
Copy link
Collaborator

Yeah, looks like it. Sorry for that coincidence, I just wanted to release the fix asap. Thank you for the contribution nevertheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet