-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on and support Android 12 (SDK 31). #640
Build on and support Android 12 (SDK 31). #640
Conversation
@Lyokone Could you have a look at this PR and get it merged? In order to support Android 12! |
Hi @Lyokone, could you have a quick look to this PR ? This is the only package left so I can migrate my app to Android 12. |
@Lyokone any updates on merging this PR to unblock everybody from building on Android 12? |
@Lyokone Any plans to merge this pull request in the near future? This issue is really blocking a lot of app releases. |
@Lyokone any updates on that current topic? Can we help? Unfortunately this prevents Android 12 devices from running the application. |
@Lyokone Please merge this PR.... |
Did not try it myself, but in the mean-time maybe everybody who is blocked can use the following: dependencies:
flutterlocation:
git:
url: [email protected]:pieteraelse/flutterlocation.git
ref: build_on_and_support_android_12_sdk_31 Source: https://dart.dev/tools/pub/dependencies#git-packages |
Thanks @PieterAelse, it works well with your fork but you have to set the path as well:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Lyokone trying to unflag as it's not stale |
How is this still not merged? Nearly half a year since the creation of the PR has passed, without any direct feedback of the maintainer @Lyokone . I understand that they are in the process of a new major version, but I think merging code from the community should still be possible in the meantime. I would greatly appreciate it (and I'm sure others would too), if you could quickly take a look at this and merge it. |
@Lyokone Any chance of the PR getting merged of the fix? btw How is everyone tackling this issue? |
@akhatriST I just forked the repo, merged the contents of all the PRs which were needed and use that repo for now. |
Can you try to contribute your fork.
The package has no changes since 3 months.
Doesn’t know whether package is orbaned orphaned/abandoned
Thanks
… Am 08.09.2022 um 09:46 schrieb Lukas Kurz ***@***.***>:
@akhatriST I just forked the repo, merged the contents of all the PRs which were needed and use that repo for now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
@Lyokone any chance to get this merged? |
@bartekpacia Since you closed #639 in favor of #702 (a newer issue? but okay..), could you review this PR to get it merged? |
Will take a look at it soon and hopefully merge
I was just trying to clean up the repo, many issues had often ~5 duplicates, so I wasn't really looking which one was newer |
The build is failing. |
@bartekpacia Looks like the main change of my PR is already done on master now: 187734c Maybe this PR can be closed, if you agree. |
Yeah, looks like it. Sorry for that coincidence, I just wanted to release the fix asap. Thank you for the contribution nevertheless! |
Fixes #639
Fixes #702