Merge pull request LykosAI#656 from ionite34/fix-sdfx-exit

Fixed Sdfx electron window not closing when stopping the app

CHANGELOG.md

@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
 - Fixed missing progress text during package updates
 - Fixed "Git and Node.js are required" error during SDFX install
 - (Windows) Fixed "Open in Explorer" buttons across the app not opening the correct path on ReFS partitions
+- (Windows) Fixed Sdfx electron window not closing when stopping the package
 - (macOS, Linux) Fixed Subprocesses of packages sometimes not being closed when the app is closed
 - Fixed Inference tabs sometimes not being restored from previous sessions
 - Fixed multiple log files being archived in a single session, and losing some log entries

StabilityMatrix.Core/Models/Packages/Sdfx.cs

@@ -140,6 +140,12 @@ void HandleConsoleOutput(ProcessOutput s)
         var args = $"\"{Path.Combine(installedPackagePath, command)}\" --run {arguments}";
 
         venvRunner.RunDetached(args.TrimEnd(), HandleConsoleOutput, OnExit);
+
+        // Cuz node was getting detached on process exit
+        if (Compat.IsWindows)
+        {
+            ProcessTracker.AttachExitHandlerJobToProcess(venvRunner.Process);
+        }
     }
 
     private Dictionary<string, string> GetEnvVars(PyVenvRunner venvRunner, DirectoryPath installPath)