Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tocpp: Support wayland #1870

Merged
merged 2 commits into from
Nov 7, 2024
Merged

tocpp: Support wayland #1870

merged 2 commits into from
Nov 7, 2024

Conversation

antonio-lunarg
Copy link
Contributor

I had a look at tocpp, noticed there was no wayland support, so I added it. Quite an easy task thanks to the wayland book.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 296965.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5309 running.

@bradgrantham-lunarg bradgrantham-lunarg requested review from charles-lunarg and removed request for locke-lunarg November 6, 2024 16:52
@bradgrantham-lunarg
Copy link
Contributor

bradgrantham-lunarg commented Nov 6, 2024 •
edited
Loading

Hey, @charles-lunarg , can take a quick scan of this with your Wayland experience in mind?

@bradgrantham-lunarg
Copy link
Contributor

@locke-lunarg you are welcome to look through this and I think your feedback would be helpful if you have any but I didn't want to gate this PR on your approval.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5309 passed.

charles-lunarg
charles-lunarg reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing looks amiss - easiest way to confirm if this works is to run tocpp with wayland and see if it compiles & runs.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 297095.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 297097.

@antonio-lunarg
Copy link
Contributor Author

@charles-lunarg Nothing looks amiss - easiest way to confirm if this works is to run tocpp with wayland and see if it compiles & runs.

It works on my machine™

It would be nice to have an automated test for this.

@antonio-lunarg antonio-lunarg self-assigned this Nov 6, 2024
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5313 running.

@locke-lunarg
Copy link
Contributor

locke-lunarg commented Nov 6, 2024 •
edited
Loading

It looks good to me. If it works on your machine, that will be good, except the default place in switch. But that's ok if that's your prefer.

I wonder if you mind to add xlib support in another PR since you just added wayland support, and they might be similar. But if they are very different, please ignore what I said.

@davidlunarg @lunarpapillo I think we need ToCpp tests in VulkanTests in the future.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5313 passed.

@locke-lunarg
Copy link
Contributor

locke-lunarg commented Nov 6, 2024 •
edited
Loading

Please add some description about Wayland support in README.md

@antonio-lunarg
tocpp: Fail for invalid platform
077cb62 
Report error in case of invalid or unsupported platform. This should
prevent silent failures and help adding support for new platforms.
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 297232.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5315 running.

@antonio-lunarg
tocpp: Support Wayland
e0cefac 
Add C++ template strings for the Wayland platform and update tocpp
README.md
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 297249.

@antonio-lunarg
Copy link
Contributor Author

Updated both default: and README.md.

@locke-lunarg locke-lunarg self-requested a review November 6, 2024 21:17
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5317 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5317 passed.

@antonio-lunarg antonio-lunarg merged commit 69a7108 into LunarG:dev Nov 7, 2024
9 checks passed
@antonio-lunarg antonio-lunarg deleted the antonio-tocpp-wayland branch November 7, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg left review comments

@bradgrantham-lunarg bradgrantham-lunarg bradgrantham-lunarg approved these changes

@locke-lunarg locke-lunarg locke-lunarg approved these changes

Assignees

@antonio-lunarg antonio-lunarg

Labels
vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antonio-lunarg @ci-tester-lunarg @bradgrantham-lunarg @locke-lunarg @charles-lunarg