Instrument GFXReconstruct with Perfetto trace markers #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perfetto is the underlying "system trace" infracsture for Android, and can provide detailed views of what all CPU tracks are doing, including the display of markers added into source code. Some Android graphics profilers add GPU information to Perfetto traces. GFXRecstruct (GFXR) is an underlying component of some of these profilers. This change allows us to see how much time is being spent on which tasks, which can allow us to optimize GFXR for new use cases. This change requires a sister directory to GFXR (perfetto). When these markers are integrated into GFXR, we need to address that. This change is a derivative of excellent work done by Mariia (Mary) Koliadenko, who pioneered the instrumentation of GFXReconstruct with Perfetto trace markers.
|
|
|
Author ianelliottus not on autobuild list. Waiting for curator authorization before starting CI build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perfetto is the underlying "system trace" infracsture for Android, and can provide detailed views of what all CPU tracks are doing, including the display of markers added into source code. Some Android graphics profilers add GPU information to Perfetto traces. GFXRecstruct (GFXR) is an underlying component of some of these profilers. This change allows us to see how much time is being spent on which tasks, which can allow us to optimize GFXR for new use cases.
This change requires a sister directory to GFXR (perfetto). When these markers are integrated into GFXR, we need to address that.
This change is a derivative of excellent work done by Mariia (Mary) Koliadenko, who pioneered the instrumentation of GFXReconstruct with Perfetto trace markers.