Combine common code from vulkan capture manager and vulkan state writer #1841
Conversation
|
CI gfxreconstruct build queued with queue ID 289791. |
|
CI gfxreconstruct build # 5221 running. |
ziga-lunarg
force-pushed
the
combine_common_capture_code
branch
from
1782d9b
to
5702885
Compare
|
CI gfxreconstruct build queued with queue ID 289807. |
|
CI gfxreconstruct build # 5222 running. |
|
CI gfxreconstruct build # 5222 passed. |
ziga-lunarg
force-pushed
the
combine_common_capture_code
branch
from
5702885
to
79d91a3
Compare
|
CI gfxreconstruct build queued with queue ID 289895. |
|
CI gfxreconstruct build # 5224 running. |
|
CI gfxreconstruct build # 5224 passed. |
| #endif | ||
| } | ||
|
|
||
| static void CommonWriteFillMemoryCmd(format::HandleId memory_id, |
There was a problem hiding this comment.
I think it would be better if instead of defining this function to pass the pointer to Writer's/Manager's WriteFillMemoryCmd as an additional argument to CommonProcessHardwareBuffer. But this would require writing a declaration for that function pointer somewhere that is common to all managers and is api agnostic since this function is referred to from a lot of places (dx12 capture manager, vulkan capture manager and state writer, and the page guard manager).
I think this gets outside of the scope of this PR so I'll just leave this here as a suggestion for a different PR.
|
CI gfxreconstruct build queued with queue ID 292515. |
|
CI gfxreconstruct build # 5259 running. |
|
CI gfxreconstruct build # 5259 passed. |
This is needed for #1812