WIP - a prototype of instrumenting GFXR with Perfetto traces. #1807
Conversation
|
Author m--koma not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
m--koma
changed the title
m--koma
changed the title
| @@ -1,5 +1,7 @@ | |||
| add_library(gfxrecon_encode STATIC "") | |||
|
|
|||
| add_library(perfetto STATIC ${CMAKE_CURRENT_LIST_DIR}/../../../../perfetto/sdk/perfetto.cc) | |||
There was a problem hiding this comment.
What does this path translate into. I needed to change this to:
/home/ianelliott/android/main1/vendor/arm/mali/valhall/cinstr/production/third_party/perfetto/vendor/sdk
where /home/ianelliott/android/main1 is one of my Android build trees.
|
|
||
| #if defined(__unix__) | ||
| extern char** environ; | ||
| #endif | ||
|
|
||
| // PERFETTO_DEFINE_CATEGORIES(perfetto::Category("GFXR").SetDescription("Events from the graphics subsystem")); |
There was a problem hiding this comment.
Why is this commented out, as are other TRACE_EVENT_* macros in this file?
| @@ -352,7 +381,7 @@ bool CommonCaptureManager::Initialize(format::ApiFamilyId api_ | |||
| // External memory takes precedence over shadow memory modes. | |||
| if (use_external_memory) | |||
| { | |||
| page_guard_memory_mode_ = kMemoryModeExternal; | |||
| page_guard_memory_mode_ = kMemoryModeExternal; | |||
There was a problem hiding this comment.
You can probably eliminate this white space:-)
| @@ -52,6 +54,7 @@ target_sources(gfxrecon_encode | |||
| target_include_directories(gfxrecon_encode | |||
| PUBLIC | |||
| ${CMAKE_BINARY_DIR} | |||
| ${GFXRECON_SOURCE_DIR}/framework) | |||
| ${GFXRECON_SOURCE_DIR}/framework | |||
| ${CMAKE_CURRENT_LIST_DIR}/../../../../perfetto/sdk) | |||
There was a problem hiding this comment.
What does this relative path translate into? I changed this to:
/home/ianelliott/android/main1/vendor/arm/mali/valhall/cinstr/production/third_party/perfetto/vendor/sdk
There was a problem hiding this comment.
Looking at my Sokatoa source tree, I see that it includes perfetto and GFXR in (I use "$(TOP)" to indicate the top of the Sokatoa source tree):
- $(TOP)/external/perfetto/sdk
- $(TOP)/external/gfxreconstruct
Therefore, the above path (from $(TOP)/external/gfxreconstruct/android/framework/encode/CMakeLists.txt)
would translate to $(TOP)/external/perfetto/sdk. True?
| @@ -106,6 +113,23 @@ CommonCaptureManager::CommonCaptureManager() : | |||
| allow_pipeline_compile_required_(false), quit_after_frame_ranges_(false), block_index_(0) | |||
| {} | |||
|
|
|||
| ParameterEncoder* CommonCaptureManager::BeginTrackedApiCallCapture(format::ApiCallId call_id) | |||
There was a problem hiding this comment.
What is this method doing? It looks like a copy of the generic one (from the header file) that could do more.
Uploaded for sharing purposes only. Please do not merge.
Would appreciate guidance if there's another recommended way to share WIP work - thanks!