Remove block_index from thread data #1746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 258618. |
|
CI gfxreconstruct build # 4848 running. |
|
CI gfxreconstruct build # 4848 failed. |
|
CI gfxreconstruct build queued with queue ID 259014. |
|
CI gfxreconstruct build # 4857 running. |
|
CI gfxreconstruct build # 4857 passed. |
bradgrantham-lunarg
approved these changes
Sep 18, 2024
bradgrantham-lunarg
added
P2
|
The current use case is to do something in a Vulkan layer upchain of GFXR, marking before calling downchain and then marking after calling downchain with the the block number. In order to exactly correspond to the command just called, having the block number in the thread seems to make the most sense. Would this PR break that expectation? |
panos-lunarg
force-pushed
the
remove_block_index_from_thread_data
branch
from
a6e5a0c
to
4162f8d
Compare
|
CI gfxreconstruct build queued with queue ID 277507. |
|
CI gfxreconstruct build # 5051 running. |
|
CI gfxreconstruct build # 5051 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.