Issue #9: Get the docroot dir from env variable and add DOCROOT var on Taskfile. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+42
to
+43
| // Get the docroot directory from the environment variable. | ||
| $docroot_dir = getenv('DOCROOT'); |
There was a problem hiding this comment.
When we talked in Slack, I thought I mentioned instead doing this by parsing out the docroot from composer.json. I actually had to do this as well over in Drainpipe:
Is there a reason this needs to be customizable outside of composer.json? I'm totally open to it if there is, I'd just like to understand why.
| include_once $bootstrap_path; | ||
| } | ||
| else { | ||
| print "bootstrap.inc file not found in the specified directory."; |
There was a problem hiding this comment.
Even if we do this from composer.json, I like this. How about we print the bootstrap path too?
Suggested change
| print "bootstrap.inc file not found in the specified directory."; | |
| print sprintf("bootstrap.inc file not found at %s", $bootstrap_path"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.