fix clippy

Lordworms · Nov 14, 2024 · d26d99f · d26d99f
1 parent e5a33d8
commit d26d99f
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/datafusion/core/src/physical_optimizer/join_filter_pushdown.rs b/datafusion/core/src/physical_optimizer/join_filter_pushdown.rs
@@ -64,10 +64,13 @@ fn optimize_impl(
 ) -> Result<Transformed<Arc<dyn ExecutionPlan>>> {
     if let Some(hashjoin_exec) = plan.as_any().downcast_ref::<HashJoinExec>() {
         join_filters.clone_from(&hashjoin_exec.dynamic_filters_pushdown);
-        let new_right = optimize_impl(hashjoin_exec.right.clone(), join_filters)?;
+        let new_right = optimize_impl(
+            Arc::<dyn ExecutionPlan>::clone(&hashjoin_exec.right),
+            join_filters,
+        )?;
         if new_right.transformed {
             let new_hash_join = HashJoinExec::try_new(
-                hashjoin_exec.left().clone(),
+                Arc::<dyn ExecutionPlan>::clone(hashjoin_exec.left()),
                 new_right.data,
                 hashjoin_exec.on.clone(),
                 hashjoin_exec.filter().cloned(),
@@ -83,9 +86,10 @@ fn optimize_impl(
         Ok(Transformed::no(plan))
     } else if let Some(parquet_exec) = plan.as_any().downcast_ref::<ParquetExec>() {
         if let Some(dynamic_filters) = join_filters {
-            let final_exec = parquet_exec
-                .clone()
-                .with_dynamic_filter(Some(dynamic_filters.clone()))?;
+            let final_exec =
+                parquet_exec.clone().with_dynamic_filter(Some(
+                    Arc::<DynamicFilterInfo>::clone(dynamic_filters),
+                ))?;
             if let Some(plan) = final_exec {
                 return Ok(Transformed::yes(plan));
             } else {
@@ -99,7 +103,8 @@ fn optimize_impl(
         let mut transformed = false;
 
         for child in children {
-            let new_child = optimize_impl(child.clone(), join_filters)?;
+            let new_child =
+                optimize_impl(Arc::<dyn ExecutionPlan>::clone(child), join_filters)?;
             if new_child.transformed {
                 transformed = true;
             }