fix: correct debug command's behavior

LiteLDev · Jan 23, 2024 · e9db611 · e9db611
1 parent 1c6e7ba
commit e9db611
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/api/EventAPI.cpp b/src/api/EventAPI.cpp
@@ -1371,9 +1371,15 @@ void InitBasicEventListeners() {
                 return false;
             }
 #ifdef LLSE_BACKEND_NODEJS
-            if (!NodeJsHelper::processConsoleNpmCmd(ev.mCommand)) return false;
+            if (!NodeJsHelper::processConsoleNpmCmd(ev.mCommand)) {
+                ev.cancel();
+                return false;
+            }
 #elif defined(LLSE_BACKEND_PYTHON)
-            if (!PythonHelper::processConsolePipCmd(ev.mCommand)) return false;
+            if (!PythonHelper::processConsolePipCmd(ev.mCommand)) {
+                ev.cancel();
+                return false;
+            }
 #endif
             // CallEvents
             std::vector<std::string> paras;
@@ -1391,7 +1397,10 @@ void InitBasicEventListeners() {
                     return false;
                 }
             } else {
-                if (isFromOtherEngine) return false;
+                if (isFromOtherEngine) {
+                    ev.cancel();
+                    return false;
+                }
 
                 // Other Cmd
                 IF_LISTENED(EVENT_TYPES::onConsoleCmd) { CallEvent(EVENT_TYPES::onConsoleCmd, String::newString(cmd)); }

diff --git a/src/main/BuiltinCommands.cpp b/src/main/BuiltinCommands.cpp
@@ -25,7 +25,7 @@ extern ScriptEngine* debugEngine;
 bool ProcessDebugEngine(const std::string& cmd) {
 #ifdef LLSE_BACKEND_PYTHON
     // process python debug seperately
-    return PythonHelper::processPythonDebugEngine(cmd;
+    return PythonHelper::processPythonDebugEngine(cmd);
 #endif
     if (isInConsoleDebugMode) {
         EngineScope enter(debugEngine);