This repository has been archived by the owner on Oct 30, 2020. It is now read-only.
Improved DB password masking to mask special characters (non alpha-numeric) as well #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen deserializing with Jackson
Conflicts: org.linkedin.util-groovy/build.gradle org.linkedin.util-groovy/src/main/groovy/org/linkedin/groovy/util/json/JsonUtils.groovy project-spec.groovy
…m.groovy TestGroovyIOUtils.groovy was apparently mistakenly removed in last merge.
| def temp = File.createTempFile("cfg2", "properties") | ||
| temp.write '<property name="db.member2.db_url" value="jdbc:oracle:thin:Encrypted-AES/CBC/PKCS5Padding(3QIdAjOKfAqcetGKhHEWez,0VWjpS2ewydmPFX8y-F3M_,umlHnS9A)@//test.prod.linkedin.com:1521/PROD_PMEM2_MEMBER2" /> \n' | ||
|
|
||
| DataMaskingInputStream stream = new DataMaskingInputStream(temp.newDataInputStream()) |
There was a problem hiding this comment.
I know this is just a test, but you are opening an input stream without ever closing it.
Why not simply use a String? Then you would not have this issue (although it is still a good practice to always close what you open).
new BytArrayInputStream(s.getBytes("UTF-8")) to get an input stream from a string...
There was a problem hiding this comment.
Very good point, correcting this test class and updating the pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that only alphanumeric characters in passwords were masked, this fix makes sure that special characters (non alphanumeric) get masked as well.