Update (ci): github action's artifact upgrade v4 #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
===================================
Coverage 78% 78%
===================================
Files 2 2
Lines 249 249
===================================
Hits 194 194
Misses 55 55 |
alleeclark
force-pushed
the
fix_ci_allee_bump_upload_download_gh_actions_artifacts
branch
24 times, most recently
from
4190006 to
aba3c02
Compare
alleeclark
force-pushed
the
fix_ci_allee_bump_upload_download_gh_actions_artifacts
branch
from
4a214b1 to
b0fb74d
Compare
alleeclark
commented
Dec 18, 2024
| @@ -40,7 +40,7 @@ dependencies: | |||
| install_flags: | |||
| - "--find-links https://download.pytorch.org/whl/cpu/torch_stable.html" | |||
| - name: typing_extensions | |||
| checkout: 4.1.1 | |||
| checkout: 4.7.1 | |||
There was a problem hiding this comment.
After updating artifacts this error was shown. A bump resolves this issue .
_ ERROR collecting _integrations/tests/integrations/lightning/boring_model.py __
tests/integrations/lightning/boring_model.py:15: in <module>
import torch
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/torch/__init__.py:1954: in <module>
_C._initExtension(_manager_path())
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/torch/cuda/__init__.py:1292: in <module>
from .memory import * # noqa: F403
/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/torch/cuda/memory.py:12: in <module>
from typing_extensions import deprecated
E ImportError: cannot import name 'deprecated' from 'typing_extensions' (/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/typing_extensions.py)
- generated xml file: /home/runner/work/ecosystem-ci/ecosystem-ci/_integrations/junit/test-project.xml -
=========================== short test summary info ============================
ERROR tests/integrations/test_lightning.py - ImportError: cannot import name 'deprecated' from 'typing_extensions' (/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/typing_extensions.py)
ERROR tests/integrations/test_lightning.py
ERROR tests/integrations/lightning/boring_model.py - ImportError: cannot import name 'deprecated' from 'typing_extensions' (/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/typing_extensions.py)
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
========================= 1 warning, 3 errors in 1.21s =========================
alleeclark
commented
Dec 18, 2024
| with open("projects.json") as fp: | ||
| data = json.load(fp) | ||
| with open("meta.json") as fp: | ||
| data.append(json.load(fp)) | ||
| for root, dirs, files in os.walk("${{ steps.download-project.outputs.download-path }}"): |
There was a problem hiding this comment.
For w/e reason this output is not that useful https://github.com/actions/download-artifact?tab=readme-ov-file#outputs and the artifact does not unpack in the current directory. Added some logic to collect the meta files from the artifacts.
|
closed since we will revisit this repo later. here is a working solution that may be referenced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (add a link to the created issue in your repository if any)
OR link your project for clarity.
We received the email below stating that we need to upgrade by January.
Here is the recommended upgrade guide that I followed.
Does this introduce breaking change?
According to Github after Jan 9th if we have not upgraded there will be issues running pipelines.
Before submitting
runtimesin config for GitHub action integration?