Fix: add missing before and after callback events for encode response #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhimrazy
requested review from
lantiga,
aniketmaurya,
ethanwharris,
Andrei-Aksionov and
Borda
as code owners
for more information, see https://pre-commit.ci
bhimrazy
changed the title
aniketmaurya
reviewed
Jan 9, 2025
| @@ -70,11 +70,14 @@ def run_streaming_loop( | |||
| ) | |||
| callback_runner.trigger_event(EventTypes.AFTER_PREDICT, lit_api=lit_api) | |||
|
|
|||
| callback_runner.trigger_event(EventTypes.BEFORE_ENCODE_RESPONSE, lit_api=lit_api) | |||
There was a problem hiding this comment.
this one is a bit tricky since y_enc_gen is a generator and the values are actually not materialized till it goes through these lines. so can't add it here.
There was a problem hiding this comment.
maybe we can show a warning to users when this callback hook is used with streaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing before and after callback events for encode response in the streaming loop
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃