Feature/password reset tweaks #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edcohen08
commented
Jul 20, 2023
•
edcohen08
commented
gone
reviewed
Jul 20, 2023
| @@ -13,7 +13,7 @@ | |||
| @focus="updateFlag" @blur="updateFlag" @input="updateFlag" | |||
| {% endif %} | |||
| x-data="input('update-{{ event_name | replace('_', '-') }}', '{{ value }}')" | |||
| x-ref="input_{{ name }}" class="input {{ input_classes }} {{attrs.class}}" {% do attrs.update({"type": type, "name": name, "value": value}) %} {{ attributes(attrs)}} /> | |||
| x-ref="input" class="input {{ input_classes }} {{attrs.class}}" {% do attrs.update({"type": type, "name": name, "value": value}) %} {{ attributes(attrs)}} /> | |||
There was a problem hiding this comment.
I think this breaks if you have mutlple imputs in a form
There was a problem hiding this comment.
as far as i could tell it works and alpinejs/alpine#900 (comment)
| @@ -0,0 +1,8 @@ | |||
| {% from 'forms/field.jinja' import field as f %} | |||
There was a problem hiding this comment.
would love to get this using the default form, perhaps means the default form needs to be updated
There was a problem hiding this comment.
i added back a default.html because it's not deprecated yet so our div.html wasn't being picked up
edcohen08
force-pushed
the
feature/password-reset-tweaks
branch
from
f832d41
to
8a865cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.