refactor: use Property API for lazy configuration & update dependencies #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 12, 2024 10:37
- Convert Extension properties to use Gradle's Property API for lazy configuration - Introduce BuildInformationAdditionBuilder for more flexible build information customization / lazy configuration - Refactor tasks to use Gradle's input/output annotations consistently - Removed afterEvaluate in Plugin - Add explicit task dependencies using dependsOn and mustRunAfter for proper task ordering - Changed gitRoot to DirectoryProperty and use @internal to fix dependsOn bug This refactoring aims to make the plugin more maintainable, extensible, and aligned with current Gradle development patterns.
- Refactor CreateBuildInformationTaskTest to use new Property-based API - Add CreateBuildInformationBuilderTaskTest to verify the new BuildInformationAdditionBuilder functionality - Introduce CreateBuildInformationGitlabCiTaskTest to ensure correct behavior with GitLab CI integration - Update FirstCommitHashTaskTest with new gitRoot config
- Refactor existing integration tests to use Property API's set() method instead of direct assignment - Add UploadBuildInformationOverwriteTaskIntegrationTest to verify overwrite functionality
- Updated Gradle Build Action to v2.4.2 in GitHub workflows to fix potential secret leakage issue.
nvima
force-pushed
the
chore/update_dependencies
branch
3 times, most recently
from
e7e00eb to
f128e8a
Compare
nvima
force-pushed
the
chore/update_dependencies
branch
2 times, most recently
from
8504f0a to
07e8ea5
Compare
Ingwersaft
approved these changes
Aug 15, 2024
nvima
force-pushed
the
chore/update_dependencies
branch
from
fddbffa to
b92fee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR significantly refactors the Octopus Deploy Gradle plugin to utilize Gradle's Property API, enabling lazy configuration for all properties.