Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support msg.stamp as an alternative to msg.header.stamp #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jobafr
Copy link

@jobafr jobafr commented Jul 11, 2024

User-Facing Changes
Support plotting with (msg).stamp in addition to (msg).header.stamp, for messages that don't wrap their timestamp in a std_msgs/Header. A similar workaround exists already for MarkerArray.

Description

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • I've updated/created the storybook file(s)
  • The release version was updated on package.json files

@laisspportugal
Copy link
Collaborator

laisspportugal commented Jul 29, 2024

Hello @jobafr,

Thank you for your contribution! We really appreaciate that.
Can you please review the following points?

  • Please add an unit tests to cover this scenario
  • Verify lint errors mentioned in the pipeline (you can check them locally by running yarn run lint:ci)
  • We also appreciate if you use our contribution guidelines to increase the version numbers.

Thanks in advance

@laisspportugal
Copy link
Collaborator

Hello @jobafr,
Due the lack of answers this PR will be close in the end of this week if the changes are not addressed.
Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants