Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load and initialise multiple MCAP files via UI #360

Merged

Conversation

luluiz
Copy link
Member

@luluiz luluiz commented Feb 5, 2025

User-Facing Changes

Description
Transferred initialisation of multi MCAP files from PoC into story branch.
This PR has no unit tests because there is another ticket just to implement the tests. This is done just to unblock the others sub-tasks of the story.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

@luluiz luluiz merged commit 68115b0 into story/load-multiple-mcaps-r1 Feb 6, 2025
9 checks passed
@luluiz luluiz deleted the feature/initialize-multiple-mcaps branch February 6, 2025 11:13
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants