Adding unit tests for FoxgloveWebSocketPlayer module #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aneuwald-ctw
requested changes
Jan 30, 2025
|
|
||
| const result = dataTypeToFullName(message); | ||
|
|
||
| expect(result).toContain("/msg/"); |
There was a problem hiding this comment.
expect(result).toBe("unit/msg/test") to be more precise
| export type ToWorkerMessage = | ||
| | { type: "open"; data: { wsUrl: string; protocols?: string[] | string } } | ||
| | { type: "close"; data: undefined } | ||
| | { type: "data"; data: string | ArrayBuffer | ArrayBufferView }; // SPDX-FileCopyrightText: Copyright (C) 2023-2024 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)<[email protected]> |
There was a problem hiding this comment.
remove ours from here and put the old one in the top of the file
| it("should not call onerror if it is undefined", () => { | ||
| mockWorker.onmessage?.({ data: { type: "error" } } as MessageEvent); | ||
|
|
||
| expect(adapter.onerror).toBeUndefined(); |
There was a problem hiding this comment.
We should expect the onerror not to have been called as well.
Suggested change
| expect(adapter.onerror).toBeUndefined(); | |
| expect(adapter.onerror).toBeUndefined(); | |
| expect(onErrorMock).not.toHaveBeenCalled(); |
| it("should not call onmessage if it is undefined", () => { | ||
| mockWorker.onmessage?.({ data: { type: "message" } } as MessageEvent); | ||
|
|
||
| expect(adapter.onmessage).toBeUndefined(); |
There was a problem hiding this comment.
We should expect the onmessage not to have been called as well.
Suggested change
| expect(adapter.onmessage).toBeUndefined(); | |
| expect(adapter.onmessage).toBeUndefined(); | |
| expect(onMessageMock).not.toHaveBeenCalled(); |
| const errorEvent = { message: "error" } as ErrorEvent; | ||
| mockWorker.onerror?.(errorEvent); | ||
|
|
||
| expect(adapter.onerror).toBeUndefined(); |
There was a problem hiding this comment.
It will be undefined since it is being set as undefined in L169. You can delete this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
N/A
Description
Added some unit tests to files that provide support for the WebSocket player, also did some refactoring on the module.
Couldn't finish testing the whole module because I was having trouble accessing private fields and methods of the websocket class.
Checklist