Fix supportedFunctions() missing 'SUMIF', 'AVERAGEIF'.

LesterLyu · Aug 14, 2020 · 9e5dba0 · 9e5dba0
1 parent cc7efc5
commit 9e5dba0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/formulas/functions/information.js b/formulas/functions/information.js
@@ -21,7 +21,6 @@ const InfoFunctions = {
     },
 
     INFO: () => {
-        throw FormulaError.NOT_IMPLEMENTED('INFO');
     },
 
     ISBLANK: (value) => {

diff --git a/formulas/functions/text.js b/formulas/functions/text.js
@@ -219,8 +219,7 @@ const TextFunctions = {
         return leftParenOrMinus ? -number : number;
     },
 
-    PHONETIC: (...params) => {
-        throw FormulaError.NOT_IMPLEMENTED('PHONETIC');
+    PHONETIC: () => {
     },
 
     PROPER: (text) => {

diff --git a/grammar/hooks.js b/grammar/hooks.js
@@ -216,16 +216,13 @@ class FormulaParser {
         const supported = [];
         const functions = Object.keys(this.functions);
         functions.forEach(fun => {
-            let res;
             try {
-                res = this.functions[fun](0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
+                const res = this.functions[fun](0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
                 if (res === undefined) return;
                 supported.push(fun);
             } catch (e) {
-                if (e instanceof FormulaError || e instanceof TypeError)
+                if (e instanceof Error)
                     supported.push(fun);
-                // else
-                //     console.log(e)
             }
         });
         return supported.sort();

diff --git a/test/test.js b/test/test.js
@@ -93,8 +93,12 @@ describe('Parsing Formulas 2', () => {
 });
 
 describe('Get supported formulas', () => {
-    const number = parser.supportedFunctions().length;
-    expect(number).to.greaterThan(200);
+    const functionsNames =  parser.supportedFunctions();
+    expect(functionsNames.length).to.greaterThan(275);
+    console.log(`Support ${functionsNames.length} functions:\n${functionsNames.join(', ')}`);
+    expect(functionsNames.includes('IFNA')).to.eq(true);
+    expect(functionsNames.includes('SUMIF')).to.eq(true);
+
 })
 
 require('./grammar/test');