Added custom secret type and attachment support for bitwardenSecret #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lerentis
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Changes look good in genreal but there are a few things missing.
could you please also implement this for templates and bump all CRD versions? kopf does not play well with mixed versions under one domain sadly.
another thing would be documentation. at least a few sentences to the readme how to use attachements and the assumptions in bitwarden/vaultwarden.
thank you very much for implementing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature #83
Added custom secret type support
Added attachment support for bitwarden secrets