Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always assign default language before checking if language is allowed #5132

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Always assign default language before checking if language is allowed #5132

wants to merge 2 commits into from

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Oct 22, 2024

TODO:

  • Fix unit tests
  • Better name for default_post_language() (also checks if language is valid)

@Nutomic Nutomic mentioned this pull request Oct 22, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines Awaiting requested review from dessalines dessalines will be requested when the pull request is marked ready for review dessalines is a code owner

@phiresky phiresky Awaiting requested review from phiresky phiresky will be requested when the pull request is marked ready for review phiresky is a code owner

@dullbananas dullbananas Awaiting requested review from dullbananas dullbananas will be requested when the pull request is marked ready for review dullbananas is a code owner

@SleeplessOne1917 SleeplessOne1917 Awaiting requested review from SleeplessOne1917 SleeplessOne1917 will be requested when the pull request is marked ready for review SleeplessOne1917 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nutomic