feat ✨: Add controller text support #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion098
requested changes
May 22, 2024
ion098
previously approved these changes
May 23, 2024
ion098
reviewed
May 24, 2024
ion098
added
enhancement
PA055
changed the title
testing in the vexide sim did not result in any errors, idk why
merged and resolved merge commits, also renamed controller.hpp/cpp into gamepad.hpp/cpp
This should fix the data aborts that would occur when running the code. Previously the code would access fields in Gamepad that were uninitialized, leading to the code crashing.
marked most functions in abstractScreen as abstract
needed to return after writing to a line, and also removed debug statements
i initialized screen cleared to the wrong value, and i forgot to clear it
the logic in the abstract screen seems weird based on the behavior
rumbles in alerts were being repeated constantly for the duration of the alert, i had to clear it after 1 iteration
still bugged, debug prints are included however commented out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
creates an abstract text screen that gets polled for updates and updates the text on the controller or rumbles
Motivation
text on the controller is really the only way to give feedback to the driver during a match, rumbles are nice too
Test Plan
WIP
Download the template for this pull request:
Note
This is auto generated from
Add Template to Pull Request