Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: No static resource 에러 해결 #28

Merged
merged 2 commits into from
Jan 29, 2025
Merged

bug: No static resource 에러 해결 #28

merged 2 commits into from
Jan 29, 2025

Conversation

yechan-kim
Copy link
Member

@yechan-kim yechan-kim commented Jan 28, 2025

✅ PR 유형

어떤 변경 사항이 있었나요?

  • 새로운 기능 추가
  • 버그 수정
  • 리팩토링
  • 코드에 영향을 주지 않는 변경사항(주석, 개행 등등..)
  • 문서 수정
  • 빌드 부분 혹은 패키지 매니저 수정
  • 테스트 코드 추가

✏️ 작업 내용

  • SecurityConfig에서 API 엔드포인트를 제외한 모든 엔드포인트의 접근 차단
  • JWT 토큰이 없는 경우
Pasted Graphic 1
  • JWT 토큰이 있는 경우
Pasted Graphic 2

AS-IS

Pasted Graphic 4 Pasted Graphic 5

TO-BE

Pasted Graphic 3 Pasted Graphic 6

🔗 관련 이슈


💡 추가 사항

  • 개발의 용이성을 위해 실제로 엔드포인트에 적용되어야 하는 설정을 주석 처리하고, permitAll 처리를 하였습니다.
    현행을 유지하는게 좋을지 아니면, 주석한 부분으로 즉시 설정을 하는 것이 좋을지 의견 부탁드립니다!

@yechan-kim yechan-kim added the 🐛 bug 버그 리포트 label Jan 28, 2025
@yechan-kim yechan-kim requested review from jwnnoh and 1winhyun January 28, 2025 16:25
@yechan-kim yechan-kim self-assigned this Jan 28, 2025
@yechan-kim yechan-kim linked an issue Jan 28, 2025 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Jan 28, 2025

Test Results

32 files  32 suites   2s ⏱️
56 tests 56 ✅ 0 💤 0 ❌
58 runs  58 ✅ 0 💤 0 ❌

Results for commit ca23e14.

♻️ This comment has been updated with latest results.

Copy link
Member

@jwnnoh jwnnoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API 연동 시, 필연적으로 인증 객체가 존재해야만 정상적으로 테스트를 할 수 있기에, 주석 처리된 부분 즉시 적용해도 무방할 것 같습니다~!!

덧붙이자면, 화이트리스트 관리 방식은 좋은 것 같아요 👍

Copy link
Member

@jwnnoh jwnnoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@1winhyun 1winhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@yechan-kim yechan-kim merged commit 124ec26 into main Jan 29, 2025
2 checks passed
@yechan-kim yechan-kim deleted the bug/#27 branch January 29, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug 버그 리포트
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 No static resource 에러 해결
3 participants