modifying 'check if node_limit was initialized' to not fail if node_limit was set to 0, moving 'set node_limit to 4000000000 if it wasnt initialized' from stopper.h to common.cc #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-node_limit is set to 4000000000 in the case that params.nodes is not initialized. -node_limit is set to params.nodes if params.nodes is initialized as 0 or another int as value
node_limits value now follows the value passed to the stopper in common.cc (= 4000000000 if params.nodes was not initialized, = params.nodes if params.nodes was initialized to an int, 0 included)
|
just a note, the PR names would be better if they actually summarize the change rather than just named the issue number. |
KarlKfoury
changed the title
you prefer a summary this detailed and descriptive? or less? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #2003