Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBGL improvements to factorize code #812

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to improve layout layer of NBGL to factorize code in Bolos UX.
This shouldn't concern any application.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

Prototype of nbgl_layoutAddLargeCaseText() has changed, but it is not used by any app (on LegderHQ)

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (96fbd22) to head (58b0ac0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the nbgl-improvements-to-factorize-code branch 2 times, most recently from 6283b2b to 918f433 Compare October 31, 2024 07:12
@nroggeman-ledger nroggeman-ledger force-pushed the nbgl-improvements-to-factorize-code branch from 918f433 to ba39b9c Compare November 7, 2024 07:12
@nroggeman-ledger nroggeman-ledger force-pushed the nbgl-improvements-to-factorize-code branch from ba39b9c to 58b0ac0 Compare November 13, 2024 08:51
@nroggeman-ledger nroggeman-ledger merged commit 98eaa57 into master Nov 13, 2024
188 checks passed
@nroggeman-ledger nroggeman-ledger deleted the nbgl-improvements-to-factorize-code branch November 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants