Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing address review after a blind signing review #795

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix crashing address review after a blind signing review. This issue is due to a shared context between blind signing review and address review, leading to a wrong release of layout. The fix consists in not using shared context anymore.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (ddfd051) to head (4a3988e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   35.76%   35.76%           
=======================================
  Files          13       13           
  Lines        1591     1591           
=======================================
  Hits          569      569           
  Misses       1022     1022           
Flag Coverage Δ
unittests 35.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit ab19595 into master Oct 10, 2024
183 of 184 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-address-review-after-blind-signing branch October 10, 2024 08:30
abonnaudet-ledger pushed a commit that referenced this pull request Oct 21, 2024
…signing

Fix crashing address review after a blind signing review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants