Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigable content use case to replace settings use case #790

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to add navigable content use case (nbgl_useCaseNavigableContent) to replace depracated settings use case (nbgl_useCaseSettings)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (b23f770) to head (75ecd28).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   35.76%   35.76%           
=======================================
  Files          13       13           
  Lines        1591     1591           
=======================================
  Hits          569      569           
  Misses       1022     1022           
Flag Coverage Δ
unittests 35.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the add-navigable-content-use-case branch 2 times, most recently from 3d7a7da to 31aac56 Compare October 1, 2024 11:35
lib_nbgl/src/nbgl_use_case.c Show resolved Hide resolved
lib_nbgl/src/nbgl_use_case.c Outdated Show resolved Hide resolved
@nroggeman-ledger nroggeman-ledger merged commit ddfd051 into master Oct 7, 2024
183 of 184 checks passed
@nroggeman-ledger nroggeman-ledger deleted the add-navigable-content-use-case branch October 7, 2024 16:05
abonnaudet-ledger pushed a commit that referenced this pull request Oct 21, 2024
Add navigable content use case to replace settings use case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants