Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syscoin and syscoin_regtest app #104

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

osiastedian
Copy link
Contributor

@osiastedian osiastedian commented Oct 17, 2023

Add Syscoin App support for CI.
https://github.com/osiastedian/ledger-app-syscoin

@tdejoigny-ledger
Copy link
Contributor

Hello @osiastedian, ty for your PR.
Could you please fill the path field (instead of null) ?

@osiastedian
Copy link
Contributor Author

Hi @tdejoigny-ledger ,

TBH I'm not sure what path to put there.
Do you mean tap root derivation path like this? /86'/57'/0'

https://github.com/osiastedian/ledger-app-syscoin/blob/develop/tests_mainnet/test_bip86.py#L20

Bitcoin has null path.
https://github.com/LedgerHQ/ledger-app-database/blob/main/app-load-params-db.json#L616

Our app is a fork of the app-bitcoin-new repo.
https://github.com/LedgerHQ/app-bitcoin-new

@tdejoigny-ledger
Copy link
Contributor

Hi @osiastedian ,

I'm talking about the derivation path. For example qtum app is also a Bitcojn clone and has his derivation path different from null. Some of Bitcoin clones are directly built from app-bitcoin (legacy app), they don't have a dedicated repository.

@tdejoigny-ledger tdejoigny-ledger merged commit 7852ae5 into LedgerHQ:main Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants