Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seed Tool application to database #103

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add Seed Tool application to database #103

merged 1 commit into from
Jan 18, 2024

Conversation

aido
Copy link
Contributor

@aido aido commented Oct 12, 2023

@tdejoigny-ledger
Copy link
Contributor

@aido ty for your PR. We need to check internally if we can integrate this tool in our app store.

@aido
Copy link
Contributor Author

aido commented Oct 13, 2023

Hi @tdejoigny-ledger,

If it helps with auditing please be aware that ~40% (the BIP39 check parts) of the code in the app-seed-tool application is a direct copy of the existing app-recovery-check application written by Ledger. Another ~40% (the Shamir's Secret Shares generation parts) is a direct copy of bc-sskr which has received an independent security audit. The remaining ~20% (the Shamir's Secret Sharing UI parts) may not be a direct copy of the app-recovery-check application but is heavily 'inspired' by it.
Additionally, the lines of code that need to be audited could be reduced quite a lot if my other request is considered: LedgerHQ/nanos-secure-sdk#64

Also, if it helps any, a retired Ledger co-founder (@btchip) has stated that this app is a good idea: :-)
https://www.reddit.com/r/ledgerwallet/comments/zhvm2q/comment/jczzymm

@aido
Copy link
Contributor Author

aido commented Oct 25, 2023

Hi @tdejoigny-ledger ,

Any movement on this?

@tdejoigny-ledger
Copy link
Contributor

@aido the discussion is ongoing internally...

@tdejoigny-ledger
Copy link
Contributor

Hi @aido, could you please rebase your PR ? ty

@xchapron-ledger
Copy link
Contributor

@aido Can you rebase locally and push force? When using the rebase feature of Github you shouldn't use the "rebase with merge option" as we want to keep a linear git history.

@aido
Copy link
Contributor Author

aido commented Jan 18, 2024

@aido Can you rebase locally and push force? When using the rebase feature of Github you shouldn't use the "rebase with merge option" as we want to keep a linear git history.

Apologies @xchapron-ledger. I think I fixed that now. I thought the GitHub options would help me but they worked against me instead. :-)

@tdejoigny-ledger tdejoigny-ledger merged commit f26d1be into LedgerHQ:main Jan 18, 2024
2 checks passed
@aido aido deleted the seed_tool branch January 18, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants