-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seed Tool application to database #103
Conversation
@aido ty for your PR. We need to check internally if we can integrate this tool in our app store. |
If it helps with auditing please be aware that ~40% (the BIP39 check parts) of the code in the app-seed-tool application is a direct copy of the existing app-recovery-check application written by Ledger. Another ~40% (the Shamir's Secret Shares generation parts) is a direct copy of bc-sskr which has received an independent security audit. The remaining ~20% (the Shamir's Secret Sharing UI parts) may not be a direct copy of the app-recovery-check application but is heavily 'inspired' by it. Also, if it helps any, a retired Ledger co-founder (@btchip) has stated that this app is a good idea: :-) |
Hi @tdejoigny-ledger , Any movement on this? |
@aido the discussion is ongoing internally... |
Hi @aido, could you please rebase your PR ? ty |
@aido Can you rebase locally and push force? When using the rebase feature of Github you shouldn't use the "rebase with merge option" as we want to keep a linear git history. |
Apologies @xchapron-ledger. I think I fixed that now. I thought the GitHub options would help me but they worked against me instead. :-) |
https://github.com/aido/app-seed-tool