💚 (release) [DSDK-500]: Push snapshot release to jfrog #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
valpinkman
force-pushed
the
chore/dsdk-500-jfrog-snapshot-rlease
branch
2 times, most recently
from
4ee7572
to
5c8ebee
Compare
valpinkman
force-pushed
the
chore/dsdk-500-jfrog-snapshot-rlease
branch
from
5c8ebee
to
4ef2077
Compare
dedsxc
approved these changes
Oct 3, 2024
valpinkman
force-pushed
the
chore/dsdk-500-jfrog-snapshot-rlease
branch
from
4ef2077
to
817e2ea
Compare
| if: steps.changesets.conclusion == 'success' | ||
| uses: LedgerHQ/actions-security/actions/sign-blob@actions/sign-blob-1 | ||
| with: | ||
| path: ./dist |
There was a problem hiding this comment.
[ASK] should we do it before changeset ? as we push the artifact to jfrog there ?
There was a problem hiding this comment.
Yes we should, it's the only way to get access to the "builds" to attest and sign (it seems going through changeset publish, and subsequently pnpm publish, does not trigger the lifecycle of a normal publish, which leads to us not being able to hook into the lifecycle to get access to the "packed" libraries)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update snapshot release to push to jfrog
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
🧐 Checklist for the PR Reviewers