💚 (dmk): Fix missing ConnectUseCase tests

.github/workflows/merge_queue.yml

@@ -12,7 +12,7 @@ concurrency:
 jobs:
   checks:
     name: Run health check and unit tests
-    runs-on: ubuntu-latest
+    runs-on: ledgerhq-device-sdk
     steps:
       - uses: actions/checkout@v4
 
@@ -25,4 +25,4 @@ jobs:
       - name: Tests
         id: unit-tests
         if: ${{ steps.health-check.conclusion == 'success' }}
-        run: pnpm test
+        run: pnpm test -- -- --maxWorkers=50%

.github/workflows/pull_request.yml

@@ -51,10 +51,10 @@ jobs:
       - name: Tests
         id: unit-tests
         if: ${{ steps.health-check.conclusion == 'success' }}
-        run: pnpm test:coverage -- --max-warnings=0
+        run: pnpm test:coverage -- --maxWorkers=50%
 
       - uses: sonarsource/sonarqube-scan-action@v4
-        if: ${{ steps.unit-tests.conclusion == 'success' && github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.fork == 'false' }}
+        if: ${{ steps.unit-tests.conclusion == 'success' && github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork }}
         env:
           SONAR_TOKEN: ${{ secrets.PUBLIC_GREEN_SONAR_TOKEN }}
           SONAR_HOST_URL: ${{ secrets.PUBLIC_SONAR_HOST_URL }}

package.json

@@ -4,6 +4,7 @@
   "private": true,
   "license": "Apache-2.0",
   "scripts": {
+    "clean": "rimraf -g **/.turbo **/.next **/coverage",
     "build": "turbo run build",
     "build:libs": "turbo run build --filter=./packages/**",
     "dev": "turbo run dev",

packages/device-management-kit/jest.config.ts

@@ -11,6 +11,7 @@ const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   setupFiles: ["<rootDir>/jest.setup.ts"],
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/device-management-kit/src/internal/device-session/service/DefaultDeviceSessionService.test.ts

@@ -38,63 +38,58 @@ describe("DefaultDeviceSessionService", () => {
     );
   });
 
+  afterEach(() => {
+    deviceSession.close();
+  });
+
   it("should have an empty sessions list", () => {
     expect(sessionService.getDeviceSessions()).toEqual([]);
-    deviceSession.close();
   });
 
   it("should add a deviceSession", () => {
     sessionService.addDeviceSession(deviceSession);
-    deviceSession.close();
     expect(sessionService.getDeviceSessions()).toEqual([deviceSession]);
   });
 
   it("should not add a deviceSession if it already exists", () => {
     sessionService.addDeviceSession(deviceSession);
     sessionService.addDeviceSession(deviceSession);
-    deviceSession.close();
     expect(sessionService.getDeviceSessions()).toEqual([deviceSession]);
   });
 
   it("should remove a deviceSession", () => {
     sessionService.addDeviceSession(deviceSession);
-    deviceSession.close();
     sessionService.removeDeviceSession(deviceSession.id);
     expect(sessionService.getDeviceSessions()).toEqual([]);
   });
 
   it("should not remove a deviceSession if it does not exist", () => {
-    deviceSession.close();
     sessionService.removeDeviceSession(deviceSession.id);
     expect(sessionService.getDeviceSessions()).toEqual([]);
   });
 
   it("should get a deviceSession", () => {
     sessionService.addDeviceSession(deviceSession);
-    deviceSession.close();
     expect(sessionService.getDeviceSessionById(deviceSession.id)).toEqual(
       Either.of(deviceSession),
     );
   });
 
   it("should not get a deviceSession if it does not exist", () => {
-    deviceSession.close();
     expect(sessionService.getDeviceSessionById(deviceSession.id)).toEqual(
       Left(new DeviceSessionNotFound()),
     );
   });
 
   it("should get all sessions", () => {
     sessionService.addDeviceSession(deviceSession);
-    deviceSession.close();
     expect(sessionService.getDeviceSessions()).toEqual([deviceSession]);
   });
 
   it("should retrieve sessionObs", () => {
     expect(sessionService.sessionsObs).toBeInstanceOf(
       Observable<DeviceSession>,
     );
-    deviceSession.close();
   });
 
   it("should emit new session", (done) => {
@@ -106,7 +101,6 @@ describe("DefaultDeviceSessionService", () => {
       },
     });
     sessionService.addDeviceSession(deviceSession);
-    deviceSession.close();
   });
 
   it("should emit previous added session", () => {
@@ -124,7 +118,6 @@ describe("DefaultDeviceSessionService", () => {
         emittedSessions.push(emittedDeviceSession);
       },
     });
-    deviceSession.close();
     lastDeviceSession.close();
     expect(emittedSessions).toEqual([deviceSession, lastDeviceSession]);
     subscription.unsubscribe();

packages/device-management-kit/src/internal/discovery/use-case/ConnectUseCase.test.ts

@@ -57,6 +57,12 @@ describe("ConnectUseCase", () => {
     managerApi = new DefaultManagerApiService(managerApiDataSource);
   });
 
+  afterEach(() => {
+    for (const session of sessionService.getDeviceSessions()) {
+      sessionService.removeDeviceSession(session.id);
+    }
+  });
+
   afterAll(() => {
     jest.restoreAllMocks();
   });
@@ -94,5 +100,6 @@ describe("ConnectUseCase", () => {
       device: stubDiscoveredDevice,
     });
     expect(sessionId).toBe(fakeSessionId);
+    sessionService.removeDeviceSession(sessionId);
   });
 });

packages/flipper-plugin-client/jest.config.ts

@@ -4,6 +4,7 @@ import type { JestConfigWithTsJest } from "ts-jest";
 const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/signer/context-module/jest.config.ts

@@ -11,6 +11,7 @@ const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   setupFiles: ["<rootDir>/jest.setup.ts"],
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/signer/signer-btc/jest.config.ts

@@ -11,6 +11,7 @@ const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   setupFiles: ["<rootDir>/jest.setup.ts"],
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/signer/signer-eth/jest.config.ts

@@ -11,6 +11,7 @@ const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   setupFiles: ["<rootDir>/jest.setup.ts"],
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/signer/signer-solana/jest.config.ts

@@ -11,6 +11,7 @@ const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   setupFiles: ["<rootDir>/jest.setup.ts"],
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/signer/signer-utils/jest.config.ts

@@ -11,6 +11,7 @@ const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   setupFiles: ["<rootDir>/jest.setup.ts"],
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

packages/transport-mock/jest.config.ts

@@ -4,6 +4,7 @@ import type { JestConfigWithTsJest } from "ts-jest";
 const config: JestConfigWithTsJest = {
   preset: "@ledgerhq/jest-config-dsdk",
   testPathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
+  modulePathIgnorePatterns: ["<rootDir>/lib/esm", "<rootDir>/lib/cjs"],
   collectCoverageFrom: [
     "src/**/*.ts",
     "!src/**/*.stub.ts",

turbo.json

@@ -8,41 +8,42 @@
       "inputs": ["src/**/*.ts", "index.ts"]
     },
     "lint": {
-      "dependsOn": ["build"],
-      "outputs": []
+      "dependsOn": ["build"]
     },
     "lint:fix": {
-      "dependsOn": ["build"],
-      "outputs": []
+      "dependsOn": ["build"]
     },
     "prettier": {
-      "dependsOn": ["^prettier"],
-      "outputs": []
+      "dependsOn": ["^prettier"]
     },
     "prettier:fix": {
-      "dependsOn": ["^prettier:fix"],
-      "outputs": []
+      "dependsOn": ["^prettier:fix"]
     },
     "dev": {
       "cache": false,
       "persistent": true
     },
     "test": {
       "dependsOn": ["^build"],
-      "outputs": [],
-      "inputs": ["src/**/*.ts", "tests/**/*.ts"]
+      "inputs": ["src/**/*.ts"]
     },
     "test:coverage": {
       "dependsOn": ["^build"],
       "outputs": ["coverage/**"],
-      "inputs": ["src/**/*.ts", "tests/**/*.ts"]
+      "inputs": ["src/**/*.ts"]
     },
     "typecheck": {
-      "dependsOn": ["^build", "^typecheck"],
-      "outputs": []
+      "dependsOn": ["^build", "^typecheck"]
+    },
+    "@ledgerhq/device-management-kit-sample#typecheck": {
+      "dependsOn": ["build", "^typecheck"]
+    },
+    "@ledgerhq/ledger-dmk-docs#typecheck": {
+      "dependsOn": ["build", "^typecheck"]
     },
     "health-check": {
-      "dependsOn": ["build", "prettier", "lint", "typecheck"]
+      "dependsOn": ["build", "prettier", "lint", "typecheck"],
+      "outputs": []
     }
   }
 }