EIP-712 buffer pairs to fill screen #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
feat/apa/eip712_buffer_pairs_to_fill_screen
branch
8 times, most recently
from
6aa5a0d
to
831371d
Compare
cedelavergne-ledger
previously approved these changes
Jun 14, 2024
…unks Also fixes EIP-712 bytes formatting for values longer than the display buffer, it would only show "..." (introduced by aa38ee9)
apaillier-ledger
force-pushed
the
feat/apa/eip712_buffer_pairs_to_fill_screen
branch
from
831371d
to
0aa3215
Compare
Also lower the EIP-712 autonext delay but slow it down for golden runs
apaillier-ledger
force-pushed
the
feat/apa/eip712_buffer_pairs_to_fill_screen
branch
from
0aa3215
to
9c426dc
Compare
cedelavergne-ledger
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include