Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NBGL EIP-712 v0 #587

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix NBGL EIP-712 v0 #587

merged 1 commit into from
May 23, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

Was using the streaming review use case when it did not have to :

  • Would show a spinner during the first page transition
  • Once on the Hold to sign page, would prevent going back to the review

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger
Fix NBGL EIP-712 v0
7ad2e89 
Was using the streaming review use case when it did not have to
@apaillier-ledger apaillier-ledger merged commit a864510 into develop May 23, 2024
126 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/nbgl_eip712_v0 branch May 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @cedelavergne-ledger