Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712 filtering improvements #583

Merged
merged 11 commits into from
May 28, 2024
Merged

EIP-712 filtering improvements #583

merged 11 commits into from
May 28, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

Filtering improvements to EIP-712 :

  • Amount formatting (with correct decimals and ticker)
  • Unix timestamp formatting

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/eip712_improvements branch 2 times, most recently from 84cc5a0 to 27edc46 Compare May 24, 2024 14:40
@apaillier-ledger apaillier-ledger merged commit 2d6a25b into develop May 28, 2024
129 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/eip712_improvements branch May 28, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apaillier-ledger @cedelavergne-ledger @fbeutin-ledger