B2CA-1558: Port Standard Makefile #570

cedelavergne-ledger · 2024-04-12T10:45:32Z

This PR cleans up the Makefile, and few fixes in the code:

Port current config on Standard App Makefile
Remove useless clones
- flare
- flare_coston
- ropsten
- goerli
Update workflows
- Add recursive checkout instead of forcing git submodule from the Makefile (and adapt the documentation)
- Remove useless workflow for ethereum-plugin-sdk auto commit
Remove useless screenshots for test_legacy_contract, and simplify associated test
Code improvements / Fix warnings
- CodeQL
- Report most modifications from PR WIP: Fuzzing #225
- replace array_hexstr and %*H format by sdk function format_hex
- Add noreturn attribute in main.c
Cleanup plugin-sdk: No need to build or copy files locally, or keep local copy of etherum-plugin-sdk files
Remove U2F support

Changes include

Bugfix (non-breaking change that solves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (change that is not backwards-compatible and/or changes current functionality)
Tests
Documentation
Other (for changes that might not fit in any category)

src_features/signMessageEIP712/ui_logic.c

- flare - flare_coston - goerli - ropsten

- No need to copy local files - No need to keep local copy of 'etherum-plugin-sdk' files - Select needed files directly from the Makefile

Makefile

tests/unit/CMakeLists.txt

Makefile

makefile_conf/chain/ethereum.mk

makefile_conf/features.mk

src/uint_common.c

src/uint_common.h

src_features/performPrivacyOperation/feature_performPrivacyOperation.h

- Fix CodeQL warnings - Port lots of improvements/fixes from PR #225 - replace 'array_hexstr' and '%*H' format by sdk function 'format_hex' - Add 'noreturn' attribute in 'main.c'

- Fix default APPNAME typo (waiting VSCode fix to remove the init here) - Find dynamically ethereum-plugin-sdk src instead of add them manually - Typo/Syntax

cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Standard-Makefile branch 2 times, most recently from 7dbca3a to e288cad Compare April 12, 2024 13:11

Cleanup .gitignore

27fe6ed

cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Standard-Makefile branch 7 times, most recently from 4d3253b to 65ff397 Compare April 15, 2024 10:06

github-advanced-security bot found potential problems Apr 15, 2024

View reviewed changes

src_features/signMessageEIP712/ui_logic.c Fixed Show fixed Hide fixed

src_features/signMessageEIP712/ui_logic.c Fixed Show fixed Hide fixed

cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Standard-Makefile branch 2 times, most recently from 427aa88 to 1c57070 Compare April 15, 2024 11:01

cedelavergne-ledger added 9 commits April 15, 2024 13:55

Remove useless screenshots for test_legacy_contract, and simplify test

b427eb2

Fix Unit Tests coverage directory

a72d741

Port current config on Standard App Makefile

f218fb8

Remove u2F support

89607ec

Fix lib_standard_app include path

85a0ebb

Remove useless clones and their icons

60a0fa2

- flare - flare_coston - goerli - ropsten

Add recursive checkout from workflows

5e21c7c

Cleanup src_plugin_sdk directory

1ddd0e9

- No need to copy local files - No need to keep local copy of 'etherum-plugin-sdk' files - Select needed files directly from the Makefile

Remove useless workflow for 'ethereum-plugin-sdk' auto commit

90d5364

cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Standard-Makefile branch 3 times, most recently from 96812fd to de0df41 Compare April 15, 2024 12:31

cedelavergne-ledger requested a review from apaillier-ledger April 15, 2024 12:54

apaillier-ledger requested changes Apr 25, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

tests/unit/CMakeLists.txt Outdated Show resolved Hide resolved

apaillier-ledger reviewed Apr 26, 2024

View reviewed changes

Makefile Show resolved Hide resolved