Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electroneum Mainnet/Testnet to supported networks #550

Closed
wants to merge 5 commits into from

Conversation

andrepatta
Copy link

@andrepatta andrepatta commented Mar 14, 2024

Description

Add Electroneum Mainnet/Testnet to supported networks in Ethereum Ledger App.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Additional comments

Resources:

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 14, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@vforgeoux-ledger
Copy link
Member

Hey @andrepatta , it looks like your icon doesn't respect the guidelines (background should be white)

@andrepatta
Copy link
Author

Hi @vforgeoux-ledger thanks for letting me know. Is it okay if I submit the correct icon on Monday?

@vforgeoux-ledger
Copy link
Member

Yes @andrepatta , we want to merge networks PR today 🙏

@andrepatta
Copy link
Author

andrepatta commented Jun 24, 2024

Done @vforgeoux-ledger

@vforgeoux-ledger
Copy link
Member

Included in #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants