fix potential oob writes

[jmartins-ledger]

Description

If there is a ticker available check if we can write the ticker and the empty space.
If the ticker_len is larger than out_buffer_size then buffer is full, return failure

Changes include

• Bugfix (non-breaking change that solves an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (change that is not backwards-compatible and/or changes current functionality)
• Tests
• Documentation
• Other (for changes that might not fit in any category)

[cedelavergne-ledger]

I would rather put this check before the previous if statement.
Then , this could be simplified with only:

if (ticker_len > 0) {
    if (out_buffer_size <= ticker_len + 1) {
        return false;
    }
    memcpy(out_buffer, ticker, ticker_len);
    out_buffer[ticker_len++] = ' ';
}

[cedelavergne-ledger]

Please rebase your branch also 😉

[cedelavergne-ledger]

Closing, because files have been moved/renamed.
This PR is now tracked here: #566