Merge pull request #657 from LedgerHQ/develop

App release 1.12.0

.github/workflows/build_and_functional_tests.yml

@@ -10,6 +10,15 @@ name: Build and run functional tests using ragger through reusable workflow
 
 on:
   workflow_dispatch:
+    inputs:
+      golden_run:
+        type: choice
+        required: true
+        default: 'Raise an error (default)'
+        description: CI behavior if the test snaphots are different than expected.
+        options:
+          - 'Raise an error (default)'
+          - 'Open a PR'
   push:
     branches:
       - master
@@ -23,14 +32,15 @@ jobs:
     uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
     with:
       upload_app_binaries_artifact: "ragger_elfs"
-      flags: "CAL_TEST_KEY=1 DOMAIN_NAME_TEST_KEY=1 SET_PLUGIN_TEST_KEY=1 NFT_TEST_KEY=1"
+      flags: "CAL_TEST_KEY=1 TRUSTED_NAME_TEST_KEY=1 SET_PLUGIN_TEST_KEY=1 NFT_TEST_KEY=1"
 
   ragger_tests:
     name: Run ragger tests using the reusable workflow
     needs: build_application
     uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
     with:
       download_app_binaries_artifact: "ragger_elfs"
+      regenerate_snapshots: ${{ inputs.golden_run == 'Open a PR' }}
 
   build_clone_app:
     name: Build Clone app using the reusable workflow
@@ -50,3 +60,4 @@ jobs:
       additional_app_binaries_artifact: "clone_elfs"
       additional_app_binaries_artifact_dir: ./tests/ragger/.test_dependencies/clone/build/
       test_options: "--with_lib_mode"
+      regenerate_snapshots: ${{ inputs.golden_run == 'Open a PR' }}

CHANGELOG.md

@@ -5,6 +5,58 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.12.0](https://github.com/ledgerhq/app-ethereum/compare/1.11.3...1.12.0) - 2024-09-27
+
+### Added
+
+- Ledger PKI support
+- Added support for swap with calldata (Thorswap / LiFi / ...)
+- (network) PulseChain Testnet
+- The app now provides the derivation path to its plugins
+- Support for Trusted Name V2 payloads
+- EIP-712 filtering on trusted names
+
+### Removed
+
+- (clone) ApothemNetwork
+- (clone) Binance Smart Chain
+- (clone) BTTC
+- (clone) Conflux eSpace
+- (clone) Cube
+- (clone) KardiaChain
+- (clone) Meter
+- (clone) MultiVAC
+- (clone) OKXChain
+- (clone) POA
+- (clone) Polygon
+- (clone) Shyft
+
+### Fixed
+
+- (network) Apothemnetwork ticker
+- Missing error handling on EIP-712, which could lead to a crash of the app
+- EIP-712 filtering on fields within an empty array (requires client support with a new APDU)
+- EIP-712 amount-join filtering with missing token information
+- EIP-712 UI-code overflow on Stax which could lead to a crash of the app
+
+### Changed
+
+- (clone) Astar Polkadot EVM, removed Ethereum derivation path
+- (clone) EnergyWebChain, removed Ethereum derivation path
+- (clone) Ethereum Classic, removed Ethereum derivation path
+- (clone) Moonbeam, removed Ethereum derivation path
+- (clone) Moonriver, removed Ethereum derivation path
+- (clone) Oasys, removed Ethereum derivation path
+- (clone) Shiden EVM, removed Ethereum derivation path
+- (clone) Songbird, removed Ethereum derivation path
+- (clone) TecraCoin, removed Ethereum derivation path
+- (clone) TecraTestnet, removed Ethereum derivation path
+- (clone) Volta, removed Ethereum derivation path
+- (clone) XDC Network, removed Ethereum derivation path
+- Now the app sends back its response immediately instead of after the Transaction/Message signed/rejected screen on Stax & Flex
+- Added blind-signing friction to EIP-712 v0 & unfiltered flows
+- EIP-712 unfiltered flow now defaults to raw/verbose mode on Stax & Flex, but adds a skip button
+
 ## [1.11.3](https://github.com/ledgerhq/app-ethereum/compare/1.11.2...1.11.3) - 2024-09-04
 
 ### Changed

Makefile

@@ -27,8 +27,6 @@ include $(BOLOS_SDK)/Makefile.defines
 
 ifeq ($(CHAIN),)
     CHAIN = ethereum
-    # Temporary definition to ensure VSCode extension works... To be cleaned later
-    APPNAME = Ethereum
 endif
 
 SUPPORTED_CHAINS = $(shell find makefile_conf/chain/ -type f -name '*.mk'| sed 's/.*\/\(.*\).mk/\1/g' | sort)
@@ -38,8 +36,8 @@ endif
 include ./makefile_conf/chain/$(CHAIN).mk
 
 APPVERSION_M = 1
-APPVERSION_N = 11
-APPVERSION_P = 3
+APPVERSION_N = 12
+APPVERSION_P = 0
 APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)
 
 # Application source files
@@ -51,9 +49,6 @@ else
 endif
 APP_SOURCE_FILES += $(filter-out ./ethereum-plugin-sdk/src/main.c, $(wildcard ./ethereum-plugin-sdk/src/*.c))
 INCLUDES_PATH += ./ethereum-plugin-sdk/src
-APP_SOURCE_FILES += ${BOLOS_SDK}/lib_standard_app/crypto_helpers.c
-APP_SOURCE_FILES += ${BOLOS_SDK}/lib_standard_app/format.c
-INCLUDES_PATH += ${BOLOS_SDK}/lib_standard_app
 
 ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX))
 NETWORK_ICONS_FILE = $(GEN_SRC_DIR)/net_icons.gen.c
@@ -80,6 +75,9 @@ ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX))
     DEFINES += ICONGLYPH_SMALL=C_chain_$(CHAIN_ID)
 endif
 
+# Don't define plugin function in the plugin SDK
+DEFINES += IS_NOT_A_PLUGIN
+
 
 # Application allowed derivation curves.
 # Possibles curves are: secp256k1, secp256r1, ed25519 and bls12381g1
@@ -141,7 +139,7 @@ ENABLE_NBGL_QRCODE = 1
 ########################################
 # These advanced settings allow to disable some feature that are by
 # default enabled in the SDK `Makefile.standard_app`.
-DISABLE_STANDARD_APP_FILES = 1
+#DISABLE_STANDARD_APP_FILES = 1
 #DISABLE_DEFAULT_IO_SEPROXY_BUFFER_SIZE = 1 # To allow custom size declaration
 #DISABLE_STANDARD_APP_DEFINES = 1 # Will set all the following disablers
 #DISABLE_STANDARD_SNPRINTF = 1
@@ -155,7 +153,7 @@ DISABLE_STANDARD_APP_FILES = 1
 #        Main app configuration        #
 ########################################
 
-DEFINES += CHAINID_COINNAME=\"$(TICKER)\" CHAIN_ID=$(CHAIN_ID)
+DEFINES += APP_TICKER=\"$(TICKER)\" APP_CHAIN_ID=$(CHAIN_ID)
 
 # Enabled Features #
 include makefile_conf/features.mk