feat: make SDK compatible with mainnet contracts #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
commented
Jan 29, 2025
| // Makes a contract call to retrieve an address, but returning a zero address if the call reverts. | ||
| func getAddressOrZero(getAddress func(*bind.CallOpts) (gethcommon.Address, error)) (gethcommon.Address, error) { | ||
| address, err := getAddress(&bind.CallOpts{}) | ||
| if errors.Is(err, gethvm.ErrExecutionReverted) { |
There was a problem hiding this comment.
This is a jsonError, and even though it results in the same error message, we can't match on it 😭
MegaRedHand
force-pushed
the
run-on-mainnet
branch
from
dbddbf8 to
0ef80f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR makes the
AllocationManagerinitialization optional in the bindings builder. This should make the SDK compatible with the current version of the contracts in mainnet.Reviewer Checklist