Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: elcontracts error handling #463

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

refactor: elcontracts error handling #463

wants to merge 1 commit into from

Conversation

damiramirez
Copy link
Contributor

@damiramirez damiramirez commented Jan 23, 2025 •
edited
Loading

What Changed?

This PR aims to return errors in a consistent way in elcontracts/writer.go, as we were sometimes using error.News and also utils.WrapsError. The idea is to use the last function from now on.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@damiramirez damiramirez marked this pull request as ready for review January 23, 2025 14:41
maximopalopoli
maximopalopoli reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@maximopalopoli maximopalopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximopalopoli maximopalopoli maximopalopoli left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damiramirez @maximopalopoli