Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce redundancy in avsRegistry writer test #462

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

refactor: reduce redundancy in avsRegistry writer test #462

wants to merge 3 commits into from

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Jan 23, 2025 •
edited
Loading

What Changed?

This PR unifies different refactor changes on avsRegistry chainWriter:

  • Changes some errors.New("context: " + err.Error()) for utils.WrapError("context", err.Error())
  • Creates the canceled context only once instead of doing it multiple times
  • Fixes a comment on avsRegistry chainWriter builder

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@maximopalopoli maximopalopoli marked this pull request as ready for review January 23, 2025 14:36
@damiramirez
Copy link
Contributor

LGTM

@pablodeymo pablodeymo changed the title refactor: reduce redundancy in avsRegistry writer refactor: reduce redundancy in avsRegistry writer test Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximopalopoli @damiramirez @pablodeymo