Unit test stake registry #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test bls op state ret
Add a function for operators to update their socket and unit tests
Added NATSPEC to updateSocket() and updated revert strings to match the actual name of the contract
Add updateSocket() and correct revert strings
Comment on lines
+279
to
+287
| /** | ||
| * @notice Updates the socket of the msg.sender given they are a registered operator | ||
| * @param socket is the new socket of the operator | ||
| */ | ||
| function updateSocket(string memory socket) external { | ||
| require(_operators[msg.sender].status == OperatorStatus.REGISTERED, "BLSRegistryCoordinatorWithIndicies.updateSocket: operator is not registered"); | ||
| emit OperatorSocketUpdate(_operators[msg.sender].operatorId, socket); | ||
| } | ||
|
|
There was a problem hiding this comment.
this should probably also be added to some interface, no?
please check for any other missing interface functions too!
ChaoticWalrus
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Small PR, nice improvements to tests -- looks like primarily making them a bit more flexible / less brittle (in particular, less usage of "magic numbers") and adding a function for an operator to update their socket.
I called out one specific instance in which a function should be added to an interface, which I definitely want to see before merging.
Otherwise it looks like there could still maybe be a bit more documentation, but IMO it's passable on this front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the stake registry