Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add event for beacon chain balance update #396

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

ypatil12
Copy link
Collaborator

@ypatil12 ypatil12 commented Jan 19, 2024

We need to handle the following indexing cases for LST & Native ETH

  • podSharesUpdate on balance updates/proving WC
  • podSharesUpdate on withdrawing as tokens
  • podSharesUpdate on withdrawing as shares
  • Deposit event when withdrawing as shares

This is needed for monitoring + will be useful for external parties to properly index shares

Companion doc: https://docs.google.com/document/d/1vjT_i9V1bAclJSS62YpCLAo3KDP2IsHVWCYjdMcfV5w/edit#heading=h.958kgw1yie6h

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Good catches all-around.

Would personally really like to see a bit more test coverage added in a follow-up PR.

@ChaoticWalrus
Copy link
Contributor

Ahhh, actually looks like there's a compiler error on this branch?

Copy link
Collaborator

@wadealexc wadealexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix compiler errors ❤️

Copy link
Collaborator

@wadealexc wadealexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Make sure to rebase!
  2. One failing test, see comment above

Otherwise, LGTM.

@wadealexc wadealexc force-pushed the fix/addBeaconChainBalanceUpdateEvent branch from 06d9ccc to a45f22e Compare January 30, 2024 20:03
@ypatil12 ypatil12 merged commit db70bb2 into m2-mainnet-fixes Jan 30, 2024
41 of 46 checks passed
@ypatil12 ypatil12 deleted the fix/addBeaconChainBalanceUpdateEvent branch January 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants