-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add event for beacon chain balance update #396
Feat: add event for beacon chain balance update #396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Good catches all-around.
Would personally really like to see a bit more test coverage added in a follow-up PR.
Ahhh, actually looks like there's a compiler error on this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix compiler errors ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make sure to rebase!
- One failing test, see comment above
Otherwise, LGTM.
06d9ccc
to
a45f22e
Compare
We need to handle the following indexing cases for LST & Native ETH
This is needed for monitoring + will be useful for external parties to properly index shares
Companion doc: https://docs.google.com/document/d/1vjT_i9V1bAclJSS62YpCLAo3KDP2IsHVWCYjdMcfV5w/edit#heading=h.958kgw1yie6h