Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized Proofs #346
Generalized Proofs #346
Changes from all commits
6b172db
ca2c983
b56976c
38dafc6
0e3f0f1
ceb5cb1
d290f04
59a328d
a6ac41a
7613bea
79d6950
258d95f
2096a24
87f6de2
a907f7e
7f45cac
e25381c
4ce6725
89db042
64f6858
673505f
eb718a2
fc2c45e
ab40644
fd6838a
7fc43a5
2d5216e
51721c0
b281a62
183dd32
1343c4d
24c4d8a
5407420
0de6c2c
2405226
cb9e679
75923d7
2e4b640
e869b1e
336e245
914ada4
f91a038
8ea334d
dcf8a04
340a819
83c5347
4e1663c
fd26c96
eb5c18e
e5054e1
53a0c4c
0720245
39ea24d
a14f62b
f7d2b8e
c533844
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't it be enabled during the upgrade and paused via regular pausing method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump on this @Sidu28
I had the same questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function should be removed, partial withdrawal processing in general outside of zk. if you think otherwise, can you write something for discussion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure where do you want me to write this? I think its pretty simple. In the event Risc0 goes down, we jjust have to make a very simple transaction (can be done via etherscan) vs an upgrade. I agree having non functional code in the contract isn't good but having Risc0 go down and being able to react really quick I think is important too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think leaving this code in reduces the trust in the system, at least in some cases.
I can see the potential for bugs in the interactions between this code and the new zk-batched proving code, but it does seem like we at least have to deal with most of these issues simply due to the upgrade happening at all.