added read functions for eigenpods #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Nov 18, 2023
gpsanant
reviewed
Nov 18, 2023
gpsanant
reviewed
Nov 18, 2023
gpsanant
reviewed
Nov 18, 2023
gpsanant
reviewed
Nov 18, 2023
gpsanant
reviewed
Nov 18, 2023
gpsanant
approved these changes
Nov 18, 2023
src/contracts/pods/EigenPod.sol
Outdated
Comment on lines
802
to
803
| require(validatorPubkey.length == 48, "EigenPod.validatorPubkeyHashToInfo must be a 48-byte BLS public key"); | ||
| bytes32 validatorPubkeyHash = _calculateValidatorPubkeyHash(validatorPubkey); |
There was a problem hiding this comment.
this is a duplicate check -- you have the same require statement in the _calculateValidatorPubkeyHash function. I think it's reasonable to delete this first check (since you also use the length check in validatorPubkeyToInfo, you should not delete the check in _calculateValidatorPubkeyHash)
ChaoticWalrus
approved these changes
Nov 27, 2023
Looks like Im gonna have to make a new PR. I will do that and request your review again |
|
closing this out. the other PR mentioned above was already created + merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this PR based on requests to access these functions. Since the pubkey hash is not simply sha256(pubkey) but rather sha256(pubkey + bytes(16)), adding these would make it easier for users to call these functions with data they have on hand. Specifically, Figment requested this.
Note: maybe worht just deleting the other functions that take in the pubkey hash if we dont use them actively for the FE?