Node v2 StoreChunks and GetChunks endpoints
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
node-v2-endpoints
branch
from
96430d4
to
baf2239
Compare
cody-littley
approved these changes
Nov 14, 2024
mooselumph
approved these changes
Nov 15, 2024
| @@ -134,3 +131,26 @@ func (n *Node) DownloadBundles(ctx context.Context, batch *corev2.Batch) ([]*cor | |||
|
|
|||
| return blobShards, rawBundles, nil | |||
| } | |||
|
|
|||
| func (n *Node) ValidateBatchV2( | |||
There was a problem hiding this comment.
Should this just go in the core/validator object?
There was a problem hiding this comment.
I moved batch header validation as another method in validator object, but kept them separated
ian-shim
force-pushed
the
node-v2-endpoints
branch
from
baf2239
to
b5e2083
Compare
For now, I added a check if the batch header has been stored and abort the entire store operation if it has been stored. |
ian-shim
force-pushed
the
node-v2-endpoints
branch
from
b5e2083
to
f3df850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implementation of v2
StoreChunksandGetChunksendpointsChecks