Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics middleware #5

Merged
merged 4 commits into from
Oct 23, 2024
Merged

feat: add metrics middleware #5

merged 4 commits into from
Oct 23, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Oct 23, 2024 •
edited
Loading

  • Add metrics middleware to have cleaner metrics for all endpoint

TODO

  • Test with actual request
  • Update grafana dashboard

@shrimalmadhur shrimalmadhur merged commit 7320f9e into master Oct 23, 2024
3 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/metrics-middleware branch October 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpabst gpabst gpabst approved these changes

@bdchatham bdchatham Awaiting requested review from bdchatham

@nelsonijih nelsonijih Awaiting requested review from nelsonijih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @gpabst