reorganize uploader docs #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @tabacitu filled the TODO. |
tabacitu
commented
Dec 5, 2024
7.x-dev/crud-uploaders.md
Outdated
Comment on lines
97
to
98
| { | ||
| } |
There was a problem hiding this comment.
This needs a little bit more info inside it. Ok so it's a method for repeatables, but what should I do inside it, to make an upload work inside repeatable subfields? I have no idea if you don't tell me.
7.x-dev/crud-uploaders.md
Outdated
Comment on lines
177
to
178
| { | ||
| } |
There was a problem hiding this comment.
Same here, no idea what to do for repeatables, if you don't tell me.
tabacitu
commented
Dec 5, 2024
tabacitu
commented
Dec 5, 2024
Co-authored-by: Cristian Tăbăcitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the titles of our Uploader docs a little bit, to make them easier to understand... and introduces a new title that I consider important - HOW TO CREATE AN UPLOADER.
We don't have a guide for that right now. And I myself don't know how uploaders work. So I think it's important to add this bit of documentation, that explains... if you want to create an Uploader here's what you do... what rules you have to respect... and WHY. That will FORCE US to basically make Uploaders understandable, by anyone (including me 😅).
@pxpm can you please fill in this TODO with actual docs on how to create an Uploader. In the process, it will help me understand Uploaders and help me review the PRs we have in the pipeline.