-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit-Test Workflows and CodeQL workflows #16
Conversation
Sorry for the delay...was pr-occupied with some other task...please tell me if you require some additional changes. @navin772 |
d440894
to
c70c341
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
.github/workflows/codeql.yml
Outdated
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use actions/checkout@v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the action results...will make the fixes/changes to resolve the warnings found in thr run
.github/workflows/codeql.yml
Outdated
# If this step fails, then you should remove it and run the build manually (see below) | ||
- name: Autobuild | ||
uses: github/codeql-action/autobuild@v2 | ||
# - run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove dead code!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had kept it as a guide. If you feel like it, I will remove it.
.github/workflows/codeql.yml
Outdated
strategy: | ||
fail-fast: false | ||
matrix: | ||
language: [ "java-kotlin" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to understabd in here. can we have ??
language: [ "java-kotlin" ] | |
language: [ "java", "kotlin" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think so...couldn't find anything exactly matching but it should work.
.github/workflows/unit-tests.yml
Outdated
uses: gradle/actions/setup-gradle@v3 | ||
|
||
- name: Run test suites | ||
run: ./gradlew test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: ./gradlew test | |
run: ./gradlew test --info |
For logs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
If there are no open issues with the PR, then can you guys get this PR merged? Also, can you please add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Overview
Issue Closed #10
Changes
unit-tests.yml workflow
codeql.yml workflow